Skip to content

Conversation

@del22123
Copy link
Collaborator

Description

Fixed refetching of Product detail graphql after adding configurable product to cart

Closes #4288

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del22123 del22123 requested a review from glo82145 November 25, 2025 12:15
@del22123 del22123 self-assigned this Nov 25, 2025
@del22123 del22123 added version: Minor This changeset includes functionality added in a backwards compatible manner. Progress: PR review labels Nov 25, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 25, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 69429fb

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 69429fb

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

Danger failed to run ./dangerfile.js.

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Error HttpError

Not Found
HttpError: Not Found
    at /codebuild/output/src3297/src/github.com/magento/pwa-studio/node_modules/@octokit/request/dist-node/index.js:86:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async checkVersionLabel (./dangerfile.js:328:9)
    at async Promise.all (index 3)

Dangerfile

81|                                     failures: failureCount,
82|                                     time
83|                                 }
84|                             },
85|                             {
-----------------------^
86|                                 testsuite: [{
87|                                         _attr: {
88|                                             name: title,
89|                                             errors: errorCount,

Generated by 🚫 dangerJS against 69429fb

@del22123
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 26, 2025

Successfully started codebuild job for lighthouse-mobile

@del22123
Copy link
Collaborator Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 26, 2025

Successfully started codebuild job for cypress

@glo82145 glo82145 merged commit b0446d4 into develop Dec 3, 2025
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:peregrine Progress: PR review version: Minor This changeset includes functionality added in a backwards compatible manner.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: PDP add to cart action will refetch the query getProductDetailForProductPage

4 participants