Skip to content

Fixing Jumping Issue on PLP and SRLP on Live Search#4479

Closed
del15881 wants to merge 1 commit intodevelopfrom
bugfix/PWA-3476-JumpIssue-Fix
Closed

Fixing Jumping Issue on PLP and SRLP on Live Search#4479
del15881 wants to merge 1 commit intodevelopfrom
bugfix/PWA-3476-JumpIssue-Fix

Conversation

@del15881
Copy link
Copy Markdown
Collaborator

@del15881 del15881 commented Jul 2, 2025

Description

Fixing the Page Jumping Issue on PLP and SRLP by fixing how variables are updated.

TODO: Describe your changes in detail here.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3476

Closes #PWA-3476.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 requested review from del22123 and glo82145 July 2, 2025 13:26
@del15881 del15881 self-assigned this Jul 2, 2025
@del15881 del15881 added the bug Something isn't working label Jul 2, 2025
@pwa-studio-bot
Copy link
Copy Markdown
Collaborator

pwa-studio-bot commented Jul 2, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • contains valid CMS Page data:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays subcategories from the default root category:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays assigned products:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,contains valid CMS Page data specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows categories specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows products specific to the categories in the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,lets users add products to cart regardless of store view:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4479.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 797acd9

@pwa-studio-bot
Copy link
Copy Markdown
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 797acd9

@pwa-studio-bot
Copy link
Copy Markdown
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unable to create scaffolded project.

DEBUG_PROJECT_CREATION=1 packages/create-pwa/bin/create-pwa

failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3476.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 797acd9

@pwa-studio-bot
Copy link
Copy Markdown
Collaborator

pwa-studio-bot commented Jul 2, 2025

Fails
🚫

node failed.

Log

Details
Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-2f3cc4d6.json

Generated by 🚫 dangerJS against 797acd9

@glo82145
Copy link
Copy Markdown
Collaborator

glo82145 commented Jul 3, 2025

run pr-test

@pwa-test-bot
Copy link
Copy Markdown

pwa-test-bot Bot commented Jul 3, 2025

Successfully started codebuild job for pr-test

@del15881 del15881 closed this Jul 3, 2025
@del15881 del15881 reopened this Jul 3, 2025
@pwa-studio-bot
Copy link
Copy Markdown
Collaborator

Fails
🚫

node failed.

Log

Details
Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-d979a22d.json

Generated by 🚫 dangerJS against 797acd9

@del15881
Copy link
Copy Markdown
Collaborator Author

del15881 commented Jul 4, 2025

closing this PR as changes are merged from #4487.

@del15881 del15881 closed this Jul 4, 2025
@glo82145 glo82145 deleted the bugfix/PWA-3476-JumpIssue-Fix branch July 9, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pkg:extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants