Changed filters of aggregations query in PLP #4362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
glo82145
previously approved these changes
Dec 17, 2024
glo82145
previously approved these changes
Dec 20, 2024
glo82145
reviewed
Dec 20, 2024
Collaborator
glo82145
left a comment
glo82145
left a comment
There was a problem hiding this comment.
Please check the failing PR test
Collaborator
|
run scaffold-pwa |
|
Successfully started codebuild job for |
Collaborator
|
run pr-deploy |
|
Successfully started codebuild job for |
Collaborator
|
run scaffold-pwa |
|
Successfully started codebuild job for |
glo82145
approved these changes
Feb 3, 2025
glo42707
added
the
version: Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the fix for Layered navigation empty filter options
Closes #PWA-3363
https://jira.corp.adobe.com/browse/PWA-3363
Acceptance
Verification Stakeholders
Specification
Verification Steps
Step 1: Navigate to PLP page
Step 2: Apply few filters
Step 3: Verify the options in layered navigations
(Options should not have any empty items)
Current result:
Empty option items are shown
Fix result:
Empty option items will be removed
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist