magento/magento2#33588: strpos() expects parameter 1 to be string, ar… by KrasnoshchokBohdan · Pull Request #40422 · magento/magento2

KrasnoshchokBohdan · 2026-01-09T10:41:58Z

Description (*)

Fixed a critical bug in the advanced search functionality where accessing dropdown/select attributes with array parameters causes a PHP warning "Undefined array key 'label'".

The issue occurred in getPreparedSearchCriteria() method when getOptionText() returns an array without a 'label' key. This happened when dropdown attributes were passed as URL array parameters (e.g., color[]=49,50).

Changes made:

Added null coalescing operator (??) on lines 405 and 412 in app/code/Magento/CatalogSearch/Model/Advanced.php to safely handle cases where the 'label' key doesn't exist in the array returned by getOptionText()
Added unit test coverage with two new test cases: color_select_without_label and color_multiselect_without_label to prevent regression

Related Pull Requests

Fixed Issues (if relevant)

Fixes strpos() expects parameter 1 to be string, array given | magento/module-eav #33588

Manual testing scenarios (*)

In Admin, navigate to Stores → Attributes → Product
Create or select a dropdown attribute (e.g., "color")
Enable "Use in Search" and "Visible in Advanced Search" for the attribute
Save the attribute and reindex if necessary
Clear cache: bin/magento cache:clean
Navigate to the storefront advanced search results page with array parameters in the URL:
- Example: /catalogsearch/advanced/result/?color[]=49,50 (where 49,50 - attr option ids)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

… | magento/module-eav Handle missing 'label' key in advanced search dropdown attributes.

m2-assistant · 2026-01-09T10:42:01Z

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

KrasnoshchokBohdan · 2026-01-09T10:43:10Z

@magento run all tests

@see

- Remove disallowed @author tag - Add explanation and @see tag to @deprecated annotation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

KrasnoshchokBohdan · 2026-02-24T09:55:36Z

@magento run all tests

engcom-Hotel

Hello @KrasnoshchokBohdan,

Thank you for the contribution!

Please look into the failed tests and also look into the below review comment.

Thank you

engcom-Hotel · 2026-03-13T10:08:29Z


    /**
-     * @deprecated 101.0.2
+     * @deprecated 101.0.2 No alternative available.


This is something seems contradict, if there no alternative then I think we should remove @see annotation or vice versa.

… | magento/module-eav Remove deprecated catalog config property reference The `@see` annotation pointing to `Advanced::getAttributes()` was removed for the deprecated `_catalogConfig` property. This change cleans up irrelevant documentation for better code clarity.

…r-issue-33588

KrasnoshchokBohdan · 2026-03-21T11:51:18Z

@magento run all tests

engcom-Dash · 2026-03-30T06:02:09Z

@magento run all tests

engcom-Dash · 2026-03-31T10:42:06Z

@magento run all tests

engcom-Dash · 2026-03-31T10:45:01Z

Hello @KrasnoshchokBohdan,

Thank you for the contribution!

Please look into the failed tests and also look into the below review comment.

Thank you

@engcom-Hotel @KrasnoshchokBohdan As this PR has been pending for quite some time, I’ve started addressing the review comments to help move it forward.

engcom-Dash · 2026-04-02T10:59:29Z

@engcom-Hotel i have fixed the suggested review comment and static test failure. Could you please review the changes so we can further proceed with this PR?

engcom-Hotel · 2026-04-06T05:37:08Z

@magento run all tests

engcom-Bravo · 2026-04-09T13:12:02Z

Hi @KrasnoshchokBohdan,

Thanks for your Contribution!!.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Please refer the screenshot.

Could you please let us know if we are still missing anything.

Thanks.

engcom-Bravo · 2026-04-16T04:12:12Z

Hi @KrasnoshchokBohdan,

As mentioned here #40422 (comment) the issue is not reproducible in Latest 2.4-develop instance Could you please let us know if we are missing anything till then moving to On Hold.

Thanks.

KrasnoshchokBohdan · 2026-04-17T14:09:51Z

@engcom-Bravo Hi! I managed to reproduce it on 2.4-develop

Screen.Recording.2026-04-17.at.17.04.17.mov

Screen.Recording.2026-04-17.at.17.07.49.mov

engcom-Bravo · 2026-04-22T09:22:15Z

Hi @KrasnoshchokBohdan,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to Reproduce

In Admin, navigate to Stores → Attributes → Product
Create or select a dropdown attribute (e.g., "color")
Enable "Use in Search" and "Visible in Advanced Search" for the attribute
Save the attribute and reindex if necessary
Clear cache: bin/magento cache:clean
Navigate to the storefront advanced search results page with array parameters in the URL:
Example: /catalogsearch/advanced/result/?color[]=49,50 (where 49,50 - attr option ids)

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Dash · 2026-04-24T10:38:02Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

engcom-Dash · 2026-04-26T19:07:37Z

A few of the functional tests are not consistent in the recent 2 builds. They are neither failing because of the PR nor part of the PR, considered to be flaky. The consistent failures are known issues, hence moving this PR to Merge in Progress.

CE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/917530c783cedc3a01f185ac3c842505/Functional/allure-report-ce/index.html#categories

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/487f189487f9b1753061ffdfaf430eee/Functional/allure-report-ce/index.html#categories

EE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/7aeb8edceca890aa02ecc2173a757fd1/Functional/allure-report-ee/index.html#categories

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/4ab086a8e0a69ec5eff5d2417d31b31c/Functional/allure-report-ee/index.html#categories

B2B
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/be53eef68be58a7b67896acf5841116a/Functional/allure-report-b2b/index.html#categories

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40422/d83c86f2701a5b8c4e50714c3d63d95e/Functional/allure-report-b2b/index.html#categories

Known Issue
TextInlineWidgetEditingSpecialCharacterTest: ACQE-9671

magento#33588: strpos() expects parameter 1 to be string, array given…

25a3a56

… | magento/module-eav Handle missing 'label' key in advanced search dropdown attributes.

Merge branch '2.4-develop' into fix-for-issue-33588

671c131

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 12, 2026

ct-prd-projects-boards-automation Bot added this to Pull Requests Dashboard Jan 12, 2026

github-project-automation Bot moved this to Pending Review in Pull Requests Dashboard Jan 12, 2026

ct-prd-projects-boards-automation Bot added the Progress: pending review label Jan 12, 2026

KrasnoshchokBohdan and others added 2 commits February 24, 2026 11:51

Merge branch '2.4-develop' into fix-for-issue-33588

29d74d5

Fix code style violations in CatalogSearch Advanced model

2ca1191

- Remove disallowed @author tag - Add explanation and @see tag to @deprecated annotation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

engcom-Charlie added this to Community Dashboard Mar 5, 2026

engcom-Charlie removed this from Pull Requests Dashboard Mar 5, 2026

engcom-Charlie moved this to Pending Review in Community Dashboard Mar 5, 2026

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Mar 5, 2026

engcom-Hotel requested changes Mar 13, 2026

View reviewed changes

engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Mar 13, 2026

ct-prd-projects-boards-automation Bot added the Progress: needs update label Mar 13, 2026

KrasnoshchokBohdan and others added 3 commits March 21, 2026 13:47

Merge branch '2.4-develop' into fix-for-issue-33588

6fe5576

Merge remote-tracking branch 'origin/fix-for-issue-33588' into fix-fo…

c114f3f

…r-issue-33588

Merge branch '2.4-develop' into fix-for-issue-33588

3131461

engcom-Dash self-assigned this Mar 31, 2026

Merge branch '2.4-develop' into fix-for-issue-33588

40aecdf

engcom-Dash and others added 2 commits April 1, 2026 14:24

Fix static test failure

1f0c129

Merge branch '2.4-develop' into fix-for-issue-33588

84e0008

engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard Apr 2, 2026

ct-prd-projects-boards-automation Bot added Progress: review and removed Progress: needs update Progress: pending review labels Apr 2, 2026

ct-prd-projects-boards-automation Bot moved this from Pending Review to Review in Progress in Community Dashboard Apr 2, 2026

Merge branch '2.4-develop' into fix-for-issue-33588

fe4605d

engcom-Hotel approved these changes Apr 6, 2026

View reviewed changes

ct-prd-projects-boards-automation Bot removed the Progress: review label Apr 6, 2026

ct-prd-projects-boards-automation Bot moved this from Review in Progress to Ready for Testing in Community Dashboard Apr 6, 2026

ct-prd-projects-boards-automation Bot added the Progress: ready for testing label Apr 6, 2026

engcom-Bravo self-assigned this Apr 9, 2026

ct-prd-projects-boards-automation Bot added Progress: testing in progress and removed Progress: ready for testing labels Apr 9, 2026

ct-prd-projects-boards-automation Bot moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 9, 2026

engcom-Bravo moved this from Testing in Progress to On Hold in Community Dashboard Apr 16, 2026

ct-prd-projects-boards-automation Bot added Progress: on hold and removed Progress: testing in progress labels Apr 16, 2026

engcom-Bravo removed the status in Community Dashboard Apr 22, 2026

engcom-Bravo moved this to Testing in Progress in Community Dashboard Apr 22, 2026

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 22, 2026

engcom-Bravo removed the Progress: on hold label Apr 22, 2026

engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 26, 2026

Conversation

KrasnoshchokBohdan commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant Bot commented Jan 9, 2026

Uh oh!

KrasnoshchokBohdan commented Jan 9, 2026

Uh oh!

KrasnoshchokBohdan commented Feb 24, 2026

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

KrasnoshchokBohdan commented Mar 21, 2026

Uh oh!

engcom-Dash commented Mar 30, 2026

Uh oh!

engcom-Dash commented Mar 31, 2026

Uh oh!

engcom-Dash commented Mar 31, 2026

Uh oh!

engcom-Dash commented Apr 2, 2026

Uh oh!

engcom-Hotel commented Apr 6, 2026

Uh oh!

engcom-Bravo commented Apr 9, 2026

Uh oh!

engcom-Bravo commented Apr 16, 2026

Uh oh!

KrasnoshchokBohdan commented Apr 17, 2026

Uh oh!

engcom-Bravo commented Apr 22, 2026

✔️ QA Passed

Uh oh!

engcom-Dash commented Apr 24, 2026

Uh oh!

engcom-Dash commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KrasnoshchokBohdan commented Jan 9, 2026 •

edited

Loading