magento/magento2#39863: Magento Catalog Product list widget returns incorrect count

[MaximLogic]

Description (*)

According to issue #39863, the catalog product widget with pagination enabled was displaying more products than configured when the total products count is not a multiple of products per page. For example, when configuring the widget with products_per_page = 5 and products_count = 9, the widget displayed 10 products total (5 on page 1, 5 on page 2) instead of the expected 9 products (5 on page 1, 4 on page 2). Additionally, the pager showed incorrect text "Items 6 to 10 of 9 total" on the second page.
The problem occurring, because in ProductsList::getBaseCollection(), the collection limit was set using setPageSize() and setCurPage() methods without considering the products_count (total limit) constraint. This caused the SQL query to fetch full page size worth of products regardless of the total limit.

Solution:
I replaced automatic pagination with manual SQL LIMIT calculation in getBaseCollection(), and added logic to calculate the correct limit: min(pageSize, max(0, totalLimit - offset)). This ensures that on the last page, only the remaining products within the total limit are fetched. Also, updated unit tests to reflect the new behavior and added test cases for edge scenarios

Fixed Issues (if relevant)

1. Fixes Magento Catalog Product list widget returns incorrect count #39863

Manual testing scenarios (*)

1. Login to Magento Admin
2. Navigate to Content → Pages
3. Select any existing page or create a new page
4. Click "Edit with Page Builder" (if you use Text Editor, skip this and next step)
5. Drag and drop a Row element, then drag HTML Code inside it
6. Click "Insert Widget" button
7. Select "Catalog Products List" widget type
8. Configure the widget:
   • Set "Number of Products per Page" = 5
   • Set "Number of Products to Display" = 9
   • Add any condition to filter products (e.g., category)
   • Save the widget configuration
9. Save the page and view it on the frontend
10. Verify page 1 displays exactly 5 products
11. Click the pagination to go to page 2
12. Expected result: Page 2 displays exactly 4 products (not 5)
13. Expected result: Pager shows "Items 6 to 9 of 9 total"
14. Expected result: Total of 9 products displayed across both pages

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @MaximLogic. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ct-prd-pr-scan]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

[MaximLogic]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[MaximLogic]

@magento run all tests

[engcom-Hotel]

Thank you @MaximLogic for making the changes.

Please have a look into the static test failures as well.

[MaximLogic]

Thank you @MaximLogic for making the changes.

Please have a look into the static test failures as well.

if you were talking about those warnings, they are not related to PR, but fixed that

[MaximLogic]

@magento run all tests

[engcom-Hotel]

Thank you @MaximLogic for making the changes. Approving this PR for further processing.

[engcom-Bravo]

Hi @MaximLogic,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Login to Magento Admin

• Navigate to Content → Pages

• Select any existing page or create a new page

• Click "Edit with Page Builder" (if you use Text Editor, skip this and next step)

• Drag and drop a Row element, then drag HTML Code inside it

• Click "Insert Widget" button

• Select "Catalog Products List" widget type

• Configure the widget:

• Set "Number of Products per Page" = 5

• Set "Number of Products to Display" = 9

• Add any condition to filter products (e.g., category)

• Save the widget configuration

• Save the page and view it on the frontend

• Verify page 1 displays exactly 5 products

• Click the pagination to go to page 2

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Integration Tests, Unit Tests

[engcom-Dash]

Few Functional B2B, CE and EE failures are not consistent in recent 2 builds. They are neither part of this PR nor failing because of the PR changes, seems to be flaky. The consistent failures are known issues and have open JIRAs.

CE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/f6e596bbdd5fa3bb677ef190b580bae6/Functional/allure-report-ce/index.html#categories

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/5634d80ecf2abaaa8a1746ce59e3dd4e/Functional/allure-report-ce/index.html#categories

EE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/bce0802c8f718a73e38196850edf2cfc/Functional/allure-report-ee/index.html#categories

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/fc4e3784761783a9d884d0a6327f6b81/Functional/allure-report-ee/index.html#categories

B2B
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/c65dbdb19682b925063a0a2f45303dd2/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40421/5de9b35df9a4561ca13053454c40874d/Functional/allure-report-b2b/index.html#categories

Integration test and Unit Tests
The failure is occurring across all PRs and is not related to this specific PR.

Known Issue
AssertSuccessMessageAppearsAfterAddingProductToCartThatContainsOutOfStockProductTest ACQE-9359
PurchaseOrderEnableDisableE2ETest ACQE-9362
AdminDisplayingCartAndCatalogPriceRulesGridsTest ACQE-9406
StorefrontArabicLocaleDobVisibleAndSaveTest ACQE-9419

Hence, Moving this PR Merge In Progress.