magento/magento2#35670: Meta tags auto generation: variables cannot be used multiple times

[MaximLogic]

Description (*)

According to issue #35670, when a field mask contains the same placeholder multiple times (e.g., {{name}}, order {{name}}), only the first occurrence was being replaced. This happened because string.replace() only replaces the first match by default.

Changed the replacement logic in import-handler.js to use split().join() pattern instead, which replaces all occurrences of the placeholder. This ensures that masks like {{name}}, order {{name}} correctly produce "Product Name, order Product Name" instead of "Product Name, order {{name}}".

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Meta tags auto generation: variables cannot be used multiple times #35670

Manual testing scenarios (*)

1. Set the meta keyword mask via CLI: bin/magento config:set catalog/fields_masks/meta_keyword '{{name}}, order {{name}}'
2. Log in to Magento Admin
3. Navigate to Catalog > Products and create a new product
4. Set the product name to "Test Product"
5. Check the meta keywords field - it should now display "Test Product, order Test Product"
6. Verify that both occurrences of {{name}} are replaced correctly

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @MaximLogic. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ct-prd-pr-scan]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

[MaximLogic]

@magento run all tests

[MaximLogic]

@magento run WebAPI Tests

[MaximLogic]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @MaximLogic,

Thank you for the contribution!

The changes looks good to us. But a small minor change requested below.

[engcom-Hotel]

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests, Unit Tests, WebAPI Tests

[engcom-Hotel]

@magento run all tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @MaximLogic,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Execute bin/magento config:set catalog/fields_masks/meta_keyword '{{name}}, order {{name}}' or set manually
• Login to Magento2 Backend
• Create a new product
• Set product name to "NEW PRODUCT"
• Check meta keywords

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Charlie]

Few test failure from Functional B2B, and EE are not consistent in recent 2 builds. They neither part of PR nor failing because of the PR changes. Seems to be flaky. The consistent failures are known issues and have the open JIRAs for them. Hence moving the PR to Merge in Progres..

Functional B2B Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/df121305181529a90a4d4eef27b50ecd/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/205f29cecfbf722421d8a866971a7b94/Functional/allure-report-b2b/index.html#categories/dad3b5a7b0574462665553fcc880a350/3f1356d5d00edbd7/

Functional CE Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/b0dc899669b62c044568ac8694b1e7fb/Functional/allure-report-ce/index.html#categories/dad3b5a7b0574462665553fcc880a350/98656a473bc5454d/

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/0d7dbcd400525e091af62d2523921c04/Functional/allure-report-ce/index.html#categories/dad3b5a7b0574462665553fcc880a350/b19d2e97cbda35e/

Functional EE Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/e4d7622778899937b66c88a7bb5b601f/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40412/002d0df89ad3fe2b350746162d754859/Functional/allure-report-ee/index.html#categories/dad3b5a7b0574462665553fcc880a350/728d2f1de6ff2f22/

Known Issues:
ACQE-9358: AdminDisplayingCartAndCatalogPriceRulesGridsTest
ACQE-9359: AssertSuccessMessageAppearsAfterAddingProductToCartThatContainsOutOfStockProductTest
ACQE-9362: PurchaseOrderEnableDisableE2ETest