Skip to content

React Native support for backbone-react-component #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
visigoth wants to merge 6 commits into
base: master
Choose a base branch
from
Open

React Native support for backbone-react-component #88

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c57bc5
Attempt to load react-native when loading react fails
visigoth Sep 24, 2015
a05dae5
Only use DOM access methods outside of react-native
visigoth Sep 24, 2015
26443b4
Require react-native instead of react first
visigoth Nov 6, 2015
5de07f7
Add peer dependency for react-native@0.14.0
visigoth Nov 6, 2015
4356d55
Use require('react-native') when requiring 0.14.0+
visigoth Nov 6, 2015
bbc2f1c
Specify react native peerDependency better
visigoth Jan 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions lib/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,19 @@
if (typeof define === 'function' && define.amd) {
define(['react', 'backbone', 'underscore'], factory);
} else if (typeof module !== 'undefined' && module.exports) {
module.exports = factory(require('react'), require('backbone'), require('underscore'));
var react = null;
var isReactNative = false;
try {
react = require('react');
} catch (error) {
react = require('React'); // React Native
Copy link
Copy Markdown
Owner

@magalhas magalhas Sep 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a while ago a React Native example project and the way the library is required is with require('react-native'). Are you sure about React?

Copy link
Copy Markdown
Owner

@magalhas magalhas Sep 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the source file in here

isReactNative = true;
}
module.exports = factory(isReactNative, react, require('backbone'), require('underscore'));
} else {
factory(root.React, root.Backbone, root._);
}
}(this, function (React, Backbone, _) {
}(this, function (isReactNative, React, Backbone, _) {
'use strict';
if (!Backbone.React) {
Backbone.React = {};
Expand Down Expand Up @@ -70,11 +78,15 @@
},
// Sets `this.el` and `this.$el` when the component mounts.
componentDidMount: function () {
this.setElement(React.findDOMNode(this));
if (isReactNative === false) {
this.setElement(React.findDOMNode(this));
}
},
// Sets `this.el` and `this.$el` when the component updates.
componentDidUpdate: function () {
this.setElement(React.findDOMNode(this));
if (isReactNative === false) {
this.setElement(React.findDOMNode(this));
}
},
// When the component gets the initial state, instance a `Wrapper` to take
// care of models and collections binding with `this.state`.
Expand Down