Lock noise-protocol at 3.0.1 to avoid breaking change.#10
Open
hackergrrl wants to merge 1 commit intomafintosh:masterfrom
Open
Lock noise-protocol at 3.0.1 to avoid breaking change.#10hackergrrl wants to merge 1 commit intomafintosh:masterfrom
hackergrrl wants to merge 1 commit intomafintosh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noise-protocol@3.0.2changed themodule.exportsof some of its inner modules from objects to functions. Since this module relies on those internals being objects, the patch release of noise-protocol caused this module to break.This fix just locks the dependency at the last working version.
This would be helpful to be merged and published as a patch release, so that we (Cabal) don't need to remember to keep pinning noise-protocol at 3.0.1 as a top-level dependency. Thanks!