Conversation
aba83cc to
7de222b
Compare
It doesn't work in our macOS 14 CI.
The tests don't compile because it's used in `NSBundle::name`.
Owner
Author
|
Damn, I ran into rust-lang/rust#138907, see e.g. the docs build for |
Owner
Author
|
I've released |
Owner
Author
|
I have triggered a rebuild of the crates that failed docs, and am now continuing the release |
Owner
Author
|
And everything has been released! 🎉 Still need to monitor the docs builds, but it'll take docs.rs a while to finish building all the crates, see their queue. EDIT: Seems like they all built correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #792, and I probably also want to mark AppKit as safe (EDIT: Done in ad2767b).
This only releases the framework crates, the changes in
objc2do not affect these. I will work towards aobjc2 v0.7.0with small breaking changes, but the framework crates should be compatible with this too, they have a dependency on it of>=0.6.2, <0.8.0, and I will make sure that the breaking changes inobjc2do not affect the framework crates.Checklist:
ci-full, such that the full CI will run.Unreleasedheader.cargo semver-checks --default-features.#[repr(packed)]in 191b5bf, and is documented in the changelog.Post merge:
cargo release --exclude block2 --exclude dispatch2 --exclude objc2 --exclude objc2-encode --exclude objc2-exception-helper --exclude objc2-proc-macros.