fix: Attribute Handling of non-strings and colorMode for roktConfig#354
fix: Attribute Handling of non-strings and colorMode for roktConfig#354BrandonStalnaker wants to merge 1 commit into
Conversation
PR SummaryMedium Risk Overview Placement attributes are now coerced to On iOS New Architecture, Android adds unit tests for attribute coercion; test Reviewed by Cursor Bugbot for commit 2530d53. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1cc7bf4. Configure here.
1cc7bf4 to
f6dac5d
Compare
f6dac5d to
2530d53
Compare

Summary
Fixes two gaps in the React Native Rokt bridge that caused placement attributes and config to be lost before reaching the native mParticle/Rokt SDK.
Problem
Changes
iOS (RNMPRokt.mm)
Extended safeExtractRoktConfigDict to extract colorMode from the TurboModule RoktConfigType on New Architecture.
Android (MPRoktModuleImpl.kt)
TypeScript
Testing Plan
Added MPRoktModuleImplTest covering number/boolean coercion and null skipping on Android.
Master Issue
Closes https://go.mparticle.com/work/REPLACEME