refactor: migrate filteredMparticleUser module to TS - #1334
Conversation
PR SummaryLow Risk Overview The factory and returned object are now typed via Reviewed by Cursor Bugbot for commit 8300f32. Bugbot is set up for automated code reviews on this repo. Configure here. |
4885be2 to
7fe4563
Compare
c1a74eb to
8300f32
Compare
|
|
Tests: unchanged (no Request: add ((mpInstance._Helpers as Dictionary).filterUserAttributes as Function)(...)Those casts undo most of the typing win from the migration. Union Merge this before #1336 (already approved). |
| } | ||
| } | ||
|
|
||
| userAttributesCopy = ((mpInstance._Helpers as Dictionary) |
There was a problem hiding this comment.
We should have an IHelpersAPI interface or something similar that can be used here.



Background
filteredMparticleUser.jswas one of the remaining JS modules used by forwarders and Rokt filtered-user construction.What Has Changed
src/filteredMparticleUser.jstosrc/filteredMparticleUser.tswith type annotationsIFilteredMparticleUserinterfaceScreenshots/Video
Checklist
Additional Notes
getAllUserAttributesis referenced via a local function so the module typechecks when invoked withoutnew(same call pattern as production call sites)Reference Issue (For employees only. Ignore if you are an outside contributor)