refactor: migrate forwardingStatsUploader module to TS - #1333
Conversation
PR SummaryLow Risk Overview The module now exposes For typing, the forwarding-stats interval is stored on Reviewed by Cursor Bugbot for commit e4f7fab. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 188c97d. Configure here.
188c97d to
e4f7fab
Compare
|
|
Tests: unchanged (no Migration looks faithful — Nit (same theme as #1262): prefer typing the surface instead of casting:
Not blocking if you want to land the rename first and follow up on types. Bugbot hits on |
| mpInstance: IMParticleWebSDKInstance | ||
| ): void { | ||
| this.startForwardingStatsTimer = function(): void { | ||
| (window.mParticle as Dictionary)._forwardingStatsTimer = setInterval( |
There was a problem hiding this comment.
Can we use IMParticleWebSDKInstance here or does that cause too many cascading issues?
alexs-mparticle
left a comment
There was a problem hiding this comment.
Looks good overall. Only one question that isn't a blocker IMO




Background
forwardingStatsUploader.jswas one of the remaining JS modules.What Has Changed
src/forwardingStatsUploader.jstosrc/forwardingStatsUploader.tswith type annotationsIForwardingStatsUploaderinterface and wired it insrc/mp-instance.tsScreenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)