chore: sync Rokt kit with upstream page-view storage refactor - #1323
chore: sync Rokt kit with upstream page-view storage refactor#1323alexs-mparticle wants to merge 1 commit into
Conversation
Ports upstream commits b428b15, 4b041a5, 7b65606 from mparticle-javascript-integration-rokt development branch (post-v1.30.2).
PR SummaryMedium Risk Overview Supporting logic moves into Reviewed by Cursor Bugbot for commit 06da278. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06da278. Configure here.
| if (this.isTargetingDisabled()) { | ||
| try { | ||
| clearPageViewsStorage(); | ||
| clearPageViews(); |
There was a problem hiding this comment.
Opt-out still forwards stored page views
Medium Severity
When noTargeting is set, init only clears the namespaced pageViews field and process skips both capture and session-end cleanup. selectPlacements still loads page views, and that read path migrates leftover mpPageViews into storage and attaches them as page_events. Partners who opted out of targeting can still send prior browsing history to Rokt.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 06da278. Configure here.
rmi22186
left a comment
There was a problem hiding this comment.
LGTM, but agents.md is missing from othis repo





Summary
kits/roktfrom upstreammParticle-integrations/mparticle-javascript-integration-roktdevelopmentbranch with unreleased commits post-v1.30.2.pageViewStorage.ts,storage.ts,utils.ts), adds a byte-budget cap on stored page views, namespaces the localStorage key with migration from the legacy key, and captures page title and canonical URL in page view events.@mparticle/web-sdkpeer/dev dependency layout, no standalone semantic-release/provenance config, Vite externalization/aliases/version define, and Node webstorage mitigation.Upstream commits included
Files changed
Test plan
Notes