fix: prevent storage quota errors during event logging#1287
Conversation
PR SummaryMedium Risk Overview Vault ( Batch uploader — Offline event/batch loads use Persistence — Regression tests cover vault outcomes, persistence save failures, and offline batch trim/retain/null-retrieve behavior. Reviewed by Cursor Bugbot for commit 23b01ea. Bugbot is set up for automated code reviews on this repo. Configure here. |
alexs-mparticle
left a comment
There was a problem hiding this comment.
A few notes toward making the storage paths purer — mostly separating decisions from side effects and consolidating the quota handling. Suggestions inline.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fdbe5d6. Configure here.
|



Background
QuotaExceededErrorsurfacing from the synchronous commerce event path, includingeCommerce.logImpression.What Has Changed
savePersistence()localStorage writes so quota failures are logged without throwing.Verification
npm run build:iifenpm run build:test-bundlenpm run test:jestnpx karma start test/karma.config.js --browsers ChromeHeadless --single-runScreenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)