Skip to content

refactor: update ecommerce module to TS#1259

Draft
jaissica12 wants to merge 1 commit into
masterfrom
refactor/SDKE-1108-update-ecommerce-module-to-TS
Draft

refactor: update ecommerce module to TS#1259
jaissica12 wants to merge 1 commit into
masterfrom
refactor/SDKE-1108-update-ecommerce-module-to-TS

Conversation

@jaissica12
Copy link
Copy Markdown
Contributor

Background

  • Migrate remaining JavaScript modules to TypeScript for improved type safety and developer experience across the SDK codebase.

What Has Changed

  • Converted src/ecommerce.js to src/ecommerce.ts with full type annotations on all methods and parameters
  • Converted test/src/tests-eCommerce.js to test/src/tests-eCommerce.ts with necessary type casts for intentional type-mismatch tests that validate error handling

Screenshots/Video

  • N/A (no UI changes)

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • No logic changes — this is a pure TypeScript conversion with type annotations added
  • Lint, build, and all 556 Jest tests pass

Reference Issue (For employees only. Ignore if you are an outside contributor)

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant