feat: add /verify skill for lint, build, and test validation#1222
feat: add /verify skill for lint, build, and test validation#1222alexs-mparticle wants to merge 3 commits intodevelopmentfrom
Conversation
PR SummaryMedium Risk Overview Updates Written by Cursor Bugbot for commit 21fd818. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
.claude/skills/verify/skill.md
Outdated
| ## Notes | ||
|
|
||
| - `npm run test:jest` runs Jest unit tests against the built output. It requires `npm run build` to complete first. | ||
| - The full Karma browser test suite (`npm run test`) is slower and typically only needed for integration-level verification. Use `test:jest` for fast feedback. |
There was a problem hiding this comment.
I'd argue that the karma tests which include a lot of integration tests are even more important than just the jest tests which are mostly unit tests. Getting fast feedback for speed sake will give the AI a false impression that it's not breaking anything. I think we should have it run both test suites.
- Add Karma integration tests alongside Jest unit tests - Remove separate build step; each test suite builds internally - Run lint before tests as a gate - Run both test suites in parallel for efficiency
Jest tests don't depend on the build output, so the build step was unnecessary and caused a race condition when running test:jest and test (karma) in parallel during /verify.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
2 participants
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)