feat: add google consent setting updates to GTM and GA4 kits#1220
Conversation
|
PR SummaryMedium Risk Overview Updates GA4 and GTM test suites to include these new consent purposes in mocked GDPR consent state, consent mapping inputs, and expected Written by Cursor Bugbot for commit e3fecdf. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| defaultAnalyticsStorageConsentWeb: 'Denied', | ||
| defaultFunctionalityStorageConsentWeb: 'Granted', | ||
| defaultPersonalizationStorageConsentWeb: 'Denied', | ||
| defaultSecurityStorageConsentWeb: 'Granted', |
There was a problem hiding this comment.
GA4 settings-defaults test missing new consent types
Low Severity
The GTM test for "consent mappings is undefined but settings defaults are defined" was updated with defaultFunctionalityStorageConsentWeb, defaultPersonalizationStorageConsentWeb, and defaultSecurityStorageConsentWeb settings and corresponding expected values, but the equivalent GA4 test at line 3356 was not. The GA4 test still only passes the original four default consent settings (defaultAdUserDataConsentSDK, etc.) and omits defaultFunctionalityStorageConsentSDK, defaultPersonalizationStorageConsentSDK, and defaultSecurityStorageConsentSDK. This means the GA4 kit's handling of the three new consent types via settings defaults (without mappings) is untested.




Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)