ci: remove semantic-release and replace with explicit versioned workflow steps#1217
Draft
nickolas-dimitrakas wants to merge 5 commits intoworkstation/3.0-Releasefrom
Draft
ci: remove semantic-release and replace with explicit versioned workflow steps#1217nickolas-dimitrakas wants to merge 5 commits intoworkstation/3.0-Releasefrom
nickolas-dimitrakas wants to merge 5 commits intoworkstation/3.0-Releasefrom
Conversation
…flow steps
The build-dist and kit-version-update responsibilities previously hidden
inside scripts/release.sh (called via semantic-release's prepareCmd hook)
are now two named, visible steps in the staging-step-1.yml release job:
1. 'Build distribution bundle' — npm run build + git add dist -f + commit
2. 'Update kit versions to X.Y.Z' — npm pkg set version for every kit in
kits/matrix.json + commit kits/**/package.json
Both steps run only on a real release (dryRun == 'false') and execute after
the existing dry-run step captures the next version, so the version is
available via steps.get-version.outputs.version.
release.config.js is updated in lockstep:
- prepareCmd removed from @semantic-release/exec (only publishCmd remains)
- kits/**/package.json removed from @semantic-release/git assets (those
package.jsons are now committed by the explicit workflow step before
semantic-release runs, so they are already clean when the git plugin
stages its assets)
The end-to-end ordering is unchanged: the two prep commits land on the
local staging branch before npx semantic-release runs; @semantic-release/git
pushes all local commits to staging; release-kits (which needs: release)
then checks out the updated staging branch and publishes each kit at the
correct version.
Refs #1210
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickolas-dimitrakas
changed the title
nickolas-dimitrakas
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| run: | | ||
| npm run build | ||
| git add dist -f | ||
| git commit -m 'chore(build): Generate latest bundle [skip ci]' |
There was a problem hiding this comment.
Build runs before version bump, embedding stale sdkVersion
High Severity
The npm run build step now runs before npx semantic-release, but the build reads version from package.json (via src/constants.ts line 1: import { version } from '../package.json') and embeds it as sdkVersion. Previously, release.sh ran inside semantic-release's prepareCmd, which executes after @semantic-release/npm bumps package.json. Now the build uses the old, pre-bump version, so every release ships dist files reporting the previous release's sdkVersion in all API requests (batch uploads, identity calls).
Additional Locations (1)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ned workflow steps Removes release.config.js entirely. All responsibilities previously owned by semantic-release are now explicit, named steps in both staging-step-1.yml and release.yml: - Version determination: a new bump_type input (major/minor/patch) on workflow_dispatch drives `npm version $bump_type --no-git-tag-version`, which bumps package.json and package-lock.json and surfaces the new version to all downstream steps via steps.get-version.outputs.version. - npm publish: explicit `npm publish` step (OIDC unchanged). - GitHub release: `gh release create` step with the same dist assets that @semantic-release/github was uploading. - Git commit + tag: explicit `git commit` and `git tag` steps; tag is pushed alongside the release branch in the final push step. The semantic-release-only job-level env block (GITHUB_TOKEN, GIT_AUTHOR_*, GIT_COMMITTER_*) is removed from both workflows; git identity is already set by the Import GPG Key step. release.yml permissions are updated from contents:read to contents:write to allow pushing the tag. Deferred: CHANGELOG.md auto-generation (was @semantic-release/changelog). Refs #1210 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickolas-dimitrakas
changed the title
The semantic-release removal applies only to the 3-step staging process (staging-step-1/2/3.yml). release.yml is a separate public/master workflow and is out of scope for this PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ment first Removes the temporary release/$RUN_NUM branch entirely. The previous pattern created the branch from development, merged it into staging inside the release job, then pushed release commits back to the temp branch and deleted it — a round-trip that also had a bug where release-kits would check out staging but staging never actually received the release commits (only the temp branch did). New approach: - sync-staging-with-development (new job): immediately after confirm-staging-branch, merges development into staging and pushes, so staging is current before any build or test runs - build-bundle now checks out staging (not development) since they are identical after the sync - release job: remove the "Merge release branch" step (staging is already synced); push directly to HEAD:staging + tag at the end - release-kits checks out staging and now correctly gets the bumped kit versions since the release job pushed to staging - create-release-branch and cleanup jobs removed entirely Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
npx semantic-releasecall.scripts/release.shfrom theprepareCmdhook and exposed thedist/build and kit version-bump as named workflow steps.What Changed
release.config.js: deletedstaging-step-1.ymlandrelease.yml:bump_typeinput (patch/minor/major) toworkflow_dispatch— this is now how the release version is determinednpx semantic-release --dry-runwith a Calculate next version step that runsnpm version $bump_type --no-git-tag-versionand exposes the result to all downstream stepsnpx semantic-releasewith four explicit named steps:package.json+package-lock.jsongit tag vX.Y.Znpm publish(OIDC unchanged)gh release createwith the same dist assets as beforeGITHUB_TOKEN,GIT_AUTHOR_*,GIT_COMMITTER_*); git identity is set by the Import GPG Key steprelease.ymlpermissions updated fromcontents: readtocontents: write(required to push the tag)Checklist
Additional Notes
@semantic-release/changelog) is deferred — updates will be manual until a replacement script is introduced.steps.get-version.outputs.versionis preserved as the step ID and output name, so therelease-kitsjob instaging-step-1.ymlcontinues to work without changes.Reference Issue (For employees only. Ignore if you are an outside contributor)