Merged
Conversation
thomson-t
approved these changes
Mar 18, 2026
jamesnrokt
approved these changes
Mar 18, 2026
jamesnrokt
left a comment
jamesnrokt
left a comment
There was a problem hiding this comment.
Approved as it looks correct. One question around the link but if it's correct we can merge
| repositories { | ||
| maven { | ||
| name = 'sonatype' | ||
| url = 'https://ossrh-staging-api.central.sonatype.com/service/local/staging/deploy/maven2/' |
There was a problem hiding this comment.
Question: Is this the correct link?
Member
Author
There was a problem hiding this comment.
Looks like it gets removed in the next PR since the next one since I split this into 2 commits (support Gradle, which assumes we are still using the previous release process), then updating the release process to adhere to Rokt, so I'm going to go ahead and merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
Summary
Update to gradle 8 because the Rokt release process for
com.vanniktech.maven.publishrequires gradle 8