feat: add FireTV to PlatformEnum#23
Merged
rmi22186 merged 3 commits intomParticle:mainfrom Mar 17, 2026
Merged
Conversation
rmi22186
reviewed
Mar 12, 2026
rmi22186
approved these changes
Mar 12, 2026
The issue is a punctuation bug in the PlatformEnum definition. Look at these two lines:
java
XBOX("xbox");
FIRE_TV("FireTV");
XBOX ends with a semicolon instead of a comma. In a Java enum, the semicolon terminates the list of constants, so FIRE_TV("FireTV"); falls outside the enum constant list and won't compile. It should be:
java
XBOX("xbox"),
FIRE_TV("FireTV");
That one-character fix (; → ,) should get your build passing.
chrismParticle
commented
Mar 17, 2026
Contributor
Author
chrismParticle
left a comment
chrismParticle
left a comment
There was a problem hiding this comment.
The issue is a punctuation bug in the PlatformEnum definition. Look at these two lines:
java
XBOX("xbox");
FIRE_TV("FireTV");
XBOX ends with a semicolon instead of a comma. In a Java enum, the semicolon terminates the list of constants, so FIRE_TV("FireTV"); falls outside the enum constant list and won't compile. It should be:
java
XBOX("xbox"),
FIRE_TV("FireTV");
That one-character fix (; → ,) should get your build passing.
rmi22186
approved these changes
Mar 17, 2026
mparticle-automation
added a commit
that referenced
this pull request
Mar 17, 2026
## [2.7.0](v2.6.0...v2.7.0) (2026-03-17) ### Features * add FireTV to PlatformEnum ([#23](#23)) ([cdf80a2](cdf80a2))
Contributor
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
FIRE_TV("FireTV")as a new enum value toDeviceInformation.PlatformEnum, enabling users of the Java Events SDK to specify Amazon Fire TV as a device platform when sending events to mParticle.Testing Plan
DeviceInformation.PlatformEnum.FIRE_TVset on the batchReference Issue