Skip to content

Conversation

@jamesnrokt
Copy link
Collaborator

Background

  • There have been instances where API keys have been committed to the code base. This PR aims to prevent that with the addition of a Trunk rule

What Has Changed

  • Trunk rule and lint workflow

Screenshots/Video

Tested by adding an API key to a file
Screenshot 2026-01-12 at 1 02 15 PM

Checklist

  • I have performed a self-review of my own code.
  • I have tested this locally.

Additional Notes

  • N/A

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • Closes N/A

@jamesnrokt jamesnrokt requested a review from a team as a code owner January 12, 2026 18:05
Copy link

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@jamesnrokt jamesnrokt merged commit 3f3c79f into main Jan 12, 2026
15 of 17 checks passed
@jamesnrokt jamesnrokt deleted the feat/add-trunk-api-key-rule branch January 12, 2026 18:43
mparticle-automation added a commit that referenced this pull request Jan 27, 2026
## [5.76.0](v5.75.1...v5.76.0) (2026-01-27)

### Features

* Add trunk rule to detect mParticle API keys ([#633](#633)) ([3f3c79f](3f3c79f))
* Update Android Gradle plugin to 8.1.0 ([#575](#575)) ([fc6a25d](fc6a25d))

### Bug Fixes

* Align ktlint rules for kits with Android Studio defaults ([#640](#640)) ([e5484a0](e5484a0))
* migrate all generic logs to Logger class ([#630](#630)) ([9c9cb33](9c9cb33))
* Override ktlint rules for kits to avoid editorconfig conflicts ([#642](#642)) ([e31027a](e31027a))

### Updates & Maintenance

* bump actions/cache from 4 to 5 ([#635](#635)) ([fb471fa](fb471fa))
* bump actions/checkout from 5 to 6 ([#631](#631)) ([a0b2442](a0b2442))
* bump actions/checkout from 5.0.0 to 6.0.1 ([#637](#637)) ([449a0b5](449a0b5))
* bump actions/setup-java from 4 to 5 ([#625](#625)) ([46823b8](46823b8))
* bump actions/upload-artifact from 5 to 6 ([#636](#636)) ([05f6133](05f6133))
* Remove empty workflow file ([#634](#634)) ([0780abd](0780abd))
* Update submodules ([d6bf37f](d6bf37f))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.76.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants