Harden addon.d overlay install validation (v1.1)#1
Draft
T-vK wants to merge 1 commit into
Draft
Conversation
Verify Magisk's addon.d source exists before copying, abort module installation when the copy fails, document the Magisk-first install requirement, and bump module version to v1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boot-patched Magisk installs do not place
99-magisk.shinto/system/addon.d, which this module overlays systemlessly until the first OTA. The originalcustomize.shcopied Magisk's addon.d script without checking that the source exists or that the copy succeeded, which could leave the module installed in a broken state.This change:
/data/adb/magisk/addon.d.shexists before copying (Magisk must be installed first)cpfails or the overlay file is missingMotivation
Fixes silent failure modes when the module is installed before Magisk, or when the copy step fails for any reason. No change to the overlay mechanism itself.
Notes for maintainer
After merge, a v1.1 GitHub release is needed for the updated
mSurvival.jsonURLs to resolve:MagiskSurvival-v1.1.zipv1.1.mdchangelogTest plan
/system/addon.d/99-magisk.shI will wait for the next LineageOS update in a couple days to properly test this before marking this PR as ready for review.