fix: drop dead snapshot analysis property

[lzehrung]

Summary

• Remove the dead top-level analysis property returned by tryLoadProjectIndexSnapshot() in src/indexer/build-cache/project-snapshot.ts.

Why

• The return type is LoadedProjectIndexSnapshot ({ index; analysisReport? }). The extra top-level analysis spread was not part of that type and was never consumed (the snapshot fast path in build-index.ts reads snapshotLoad.analysisReport).
• It compiled only because conditional object spreads bypass TypeScript excess-property checks, so it was silent dead code. The live analysis path is the embedded index.analysis, which summarizeAnalysis() reads.
• Follow-up to the post-merge review feedback on PR fix: tighten review-first workflows and cache reuse #139 (Copilot, project-snapshot.ts:129).

Test plan

• npm run check (lint + format + build + test:fast): 173 files, 1966 passed | 1 skipped
• npx vitest run tests/cache-invalidation.test.ts tests/session.test.ts: 97 passed

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

• src/indexer/build-cache/project-snapshot.ts

---

_{Reviewed by kimi-k2.6-20260420 · Input: 21.2K · Output: 1.3K · Cached: 61.4K}