Skip to content

[WRONG BRANCH] fix(codex): bind prompt journal recovery paths - #60

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-untrusted-journal-vulnerability
Draft

[WRONG BRANCH] fix(codex): bind prompt journal recovery paths#60
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-untrusted-journal-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Recovery trusted journal-decoded configPath/storePath values and could be induced by a forged journal to create or overwrite arbitrary files under the opencodex user; checksum-only integrity does not prevent forgery.
  • The fix ensures recovery is only allowed for journal records that match the active prompt-layer targets so a planted journal in CODEX_HOME cannot point at unrelated paths.

Description

  • Change recoverIfNeeded to accept expectedConfigPath and expectedStorePath and return recovery_required if the decoded record's paths do not match the expected active paths.
  • Update the prompt-layer transaction (commit in src/codex/prompt-layers.ts) to pass the trusted configPath and storePath into recovery before any target is read or written.
  • Add a focused regression test in tests/codex-prompt-journal.test.ts that proves a valid checksum journal targeting different paths is rejected and left intact without modifying active files.
  • Preserve the existing envelope checksum and classification logic; this change binds the decoded record to the runtime-chosen targets before any restore occurs.

Testing

  • Ran the focused tests bun test tests/codex-prompt-journal.test.ts tests/codex-prompt-layers-write.test.ts and they passed (41 tests across those files).
  • Ran bun run typecheck and bun run privacy:scan, both passed.
  • Ran broader bun run test which exercised the full suite; unrelated management-auth expectation failures and several network/proxy timeouts appeared in other areas of the suite and are not caused by this change, so the focused tests that exercise the modified code were used to validate the fix.
  • git diff --check and the repository privacy scan passed for the modified files.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ab42d9fd-aa33-4309-95b5-6e6de6d13a1d

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and f4d939e.

📒 Files selected for processing (3)
  • src/codex/prompt-journal.ts
  • src/codex/prompt-layers.ts
  • tests/codex-prompt-journal.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix(codex): bind prompt journal recovery paths [WRONG BRANCH] fix(codex): bind prompt journal recovery paths Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 13:38
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant