Skip to content

[WRONG BRANCH] fix(update): scope Windows restart cleanup - #59

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-windows-service-wrapper-issue
Draft

[WRONG BRANCH] fix(update): scope Windows restart cleanup#59
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-windows-service-wrapper-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent an overbroad post-update restart path from terminating unrelated processes by removing permissive kill behavior and by narrowing the Windows wrapper-kill selector to the configured OpenCodex home.
  • Restore the original allowlist semantics so a reclaim only authorizes kills for explicitly trusted PIDs rather than any verified listener on the port.
  • Avoid accidental availability impact across multiple OpenCodex homes or same-user processes whose command line contains the wrapper basenames.

Description

  • Stop unconditionally enabling killAllOcxOnPort for restart reclaim by removing the unconditional killAllOcxOnPort: true from the reclaimOptsFor options so kills require an explicit allowlist snapshot.
  • Replace the basename substring PowerShell matcher with buildWindowsServiceWrapperCleanupScript(configDir) which scopes cleanup to getConfigDir()-anchored wrapper paths and requires the expected host executable (cmd.exe or wscript.exe) before calling Stop-Process.
  • Export buildWindowsServiceWrapperCleanupScriptForTests and update tests to assert the new PowerShell script is properly scoped and escaped, and to verify restart reclaim no longer sets killAllOcxOnPort when the pre-wait PID snapshot is empty.

Testing

  • Ran bun run typecheck and it completed successfully.
  • Ran bun test tests/port-reclaim.test.ts and all tests passed.
  • Ran bun test tests/update-job.test.ts and the updated tests passed.
  • Ran the full test suite with bun run test and bun run privacy:scan, both of which completed successfully.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eb173813-caed-44a6-82be-945cc8ea2db3

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 4e34ad2.

📒 Files selected for processing (2)
  • src/update/job.ts
  • tests/update-job.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(update): scope Windows restart cleanup [WRONG BRANCH] fix(update): scope Windows restart cleanup Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant