[WRONG BRANCH] fix(update): scope Windows restart cleanup - #59
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
killAllOcxOnPortfor restart reclaim by removing the unconditionalkillAllOcxOnPort: truefrom thereclaimOptsForoptions so kills require an explicit allowlist snapshot.buildWindowsServiceWrapperCleanupScript(configDir)which scopes cleanup togetConfigDir()-anchored wrapper paths and requires the expected host executable (cmd.exeorwscript.exe) before callingStop-Process.buildWindowsServiceWrapperCleanupScriptForTestsand update tests to assert the new PowerShell script is properly scoped and escaped, and to verify restart reclaim no longer setskillAllOcxOnPortwhen the pre-wait PID snapshot is empty.Testing
bun run typecheckand it completed successfully.bun test tests/port-reclaim.test.tsand all tests passed.bun test tests/update-job.test.tsand the updated tests passed.bun run testandbun run privacy:scan, both of which completed successfully.