[WRONG BRANCH] fix(security): harden sidebar gh resolution - #54
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Motivation
ghplanted in the project or caller PATH.Description
ghspawn with a resolver that only acceptsghfrom fixed, absolute install roots and returnsnullwhen none are found, implemented insrc/github/star-state.ts.ghfrom the user's home directory with a sanitizedPATHso automated sidebar polls cannot search the project or caller-controlled PATH.commandInvocationlogic for cross-platform.cmd/.exehandling and preserve existing timeouts and output-suppression behavior.tests/sidebar-star-state.test.tsproving untrusted POSIX and relative Windows search locations are ignored.Testing
bun test tests/sidebar-star-state.test.tsand the new POSIX/Windows resolution tests passed (14 passes, 0 fails).bun run typecheckwhich completed successfully.bun run test; the sidebar-focused changes did not cause regressions but a pre-existing unrelatedservice diagnosticsexpectation failed during a full run (investigation outside this patch).fix(security): harden sidebar gh resolutionafter the focused tests and typecheck passed.Codex Task