Skip to content

[WRONG BRANCH] fix(ci): reject renamed-away tests as regression coverage - #51

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-pr-hygiene-logic-for-test-paths
Draft

[WRONG BRANCH] fix(ci): reject renamed-away tests as regression coverage#51
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-pr-hygiene-logic-for-test-paths

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The PR hygiene check merged previous_filename into the paths used to decide whether tests changed, which let a test file renamed out of the tests/ tree (previous filename only) satisfy testsChanged and bypass the missing_regression_test gate.

Description

  • Compute testsChanged from the current filenames only (not allPaths) so that only existing, non-removed test paths count as regression coverage by changing const testsChanged = filenames.some(...) in .github/scripts/pr-hygiene.cjs.
  • Add a focused unit test does not count renamed-away tests as regression coverage in .github/scripts/pr-hygiene.test.cjs that reproduces the rename-away scenario and verifies the gate emits missing_regression_test.

Testing

  • Ran node --test .github/scripts/pr-hygiene.test.cjs, which passed including the new regression test.
  • Ran bun run typecheck and bun run privacy:scan, both of which passed.
  • Attempted the full-suite bun run test / bun run prepush, but unrelated existing tests timed out or failed in tests/service.test.ts and tests/management-provider-validation.test.ts, so the full-suite gate was not fully green in this environment.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 182013a1-1769-43ba-93af-e056aca516e6

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and ed2e10d.

📒 Files selected for processing (2)
  • .github/scripts/pr-hygiene.cjs
  • .github/scripts/pr-hygiene.test.cjs

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(ci): reject renamed-away tests as regression coverage [WRONG BRANCH] fix(ci): reject renamed-away tests as regression coverage Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 11:16
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant