[WRONG BRANCH] fix(ci): reject renamed-away tests as regression coverage - #51
[WRONG BRANCH] fix(ci): reject renamed-away tests as regression coverage#51luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
✅ Deterministic PR hygiene checks passed. |
Motivation
previous_filenameinto the paths used to decide whether tests changed, which let a test file renamed out of thetests/tree (previous filename only) satisfytestsChangedand bypass themissing_regression_testgate.Description
testsChangedfrom the currentfilenamesonly (notallPaths) so that only existing, non-removed test paths count as regression coverage by changingconst testsChanged = filenames.some(...)in.github/scripts/pr-hygiene.cjs.does not count renamed-away tests as regression coveragein.github/scripts/pr-hygiene.test.cjsthat reproduces the rename-away scenario and verifies the gate emitsmissing_regression_test.Testing
node --test .github/scripts/pr-hygiene.test.cjs, which passed including the new regression test.bun run typecheckandbun run privacy:scan, both of which passed.bun run test/bun run prepush, but unrelated existing tests timed out or failed intests/service.test.tsandtests/management-provider-validation.test.ts, so the full-suite gate was not fully green in this environment.Codex Task