Skip to content

[WRONG BRANCH] fix(ci): reject private (‘#’) and generator (‘*’) members as comment-only changes - #50

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-comment-only-gate-issue
Draft

[WRONG BRANCH] fix(ci): reject private (‘#’) and generator (‘*’) members as comment-only changes#50
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-comment-only-gate-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The PR hygiene helper isCommentOnlyChange treated lines beginning with # or * as comments, which allowed valid TypeScript/JavaScript behavior changes (private class members and generator methods) to bypass the missing_regression_test gate.
  • The intent is to permit purely comment/whitespace edits to skip the regression-test requirement while still flagging any real source changes under src/ or gui/src/.

Description

  • Rewrote isCommentOnlyChange in .github/scripts/pr-hygiene.cjs to parse diff hunks, track block-comment state separately for removed and added sides, and only treat a leading * as a comment continuation when the parser is actually inside a block comment.
  • The new logic no longer classifies lines starting with # or * (outside a block comment) as comments and returns false if any added/removed line is real code.
  • Added tests in .github/scripts/pr-hygiene.test.cjs that assert private # members and generator * members are treated as behavior changes and that block-comment continuation is only recognized when inside a block comment.

Testing

  • Ran node --test .github/scripts/pr-hygiene.test.cjs, which passed all tests (23 tests, 0 failures).
  • Ran repository checks including bun run typecheck, bun run lint:gui, and bun run privacy:scan, which completed (typecheck/lint/scan stages finished as shown).
  • The full bun run test / bun run prepush execution experienced unrelated environment-dependent timeouts and registry 403 errors in some integration tests (external network/registry failures and long-running timeouts), so the complete suite could not be fully validated here; the focused hygiene unit tests and static checks passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 474dd4a5-3025-4201-a838-df3c10c0e806

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 7a90d22.

📒 Files selected for processing (2)
  • .github/scripts/pr-hygiene.cjs
  • .github/scripts/pr-hygiene.test.cjs

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix(ci): reject private (‘#’) and generator (‘*’) members as comment-only changes [WRONG BRANCH] fix(ci): reject private (‘#’) and generator (‘*’) members as comment-only changes Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 11:15
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant