[WRONG BRANCH] fix(ci): reject private (‘#’) and generator (‘*’) members as comment-only changes - #50
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
✅ Deterministic PR hygiene checks passed. |
Motivation
isCommentOnlyChangetreated lines beginning with#or*as comments, which allowed valid TypeScript/JavaScript behavior changes (private class members and generator methods) to bypass themissing_regression_testgate.src/orgui/src/.Description
isCommentOnlyChangein.github/scripts/pr-hygiene.cjsto parse diff hunks, track block-comment state separately for removed and added sides, and only treat a leading*as a comment continuation when the parser is actually inside a block comment.#or*(outside a block comment) as comments and returnsfalseif any added/removed line is real code..github/scripts/pr-hygiene.test.cjsthat assert private#members and generator*members are treated as behavior changes and that block-comment continuation is only recognized when inside a block comment.Testing
node --test .github/scripts/pr-hygiene.test.cjs, which passed all tests (23tests,0failures).bun run typecheck,bun run lint:gui, andbun run privacy:scan, which completed (typecheck/lint/scan stages finished as shown).bun run test/bun run prepushexecution experienced unrelated environment-dependent timeouts and registry 403 errors in some integration tests (external network/registry failures and long-running timeouts), so the complete suite could not be fully validated here; the focused hygiene unit tests and static checks passed.