Skip to content

[WRONG BRANCH] fix(grok): keep slow uploads outside toggle flight - #49

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-toggle-delay-issue
Draft

[WRONG BRANCH] fix(grok): keep slow uploads outside toggle flight#49
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-toggle-delay-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Grok toggle previously acquired the module-global grokToggleFlight before awaiting the request body, so a stalled/partial upload could hold the lock and cause authenticated 409 config_busy denial-of-service for other toggles.
  • The change aims to prevent a slow client upload from monopolizing the single-flight guard while preserving the existing serialized mutation semantics.

Description

  • Parse and validate the management request body up-front in handleGrokToggle by calling readManagementJsonBody(req) before checking/setting grokToggleFlight, so stalled uploads cannot hold the flight.
  • Add a regression test an incomplete request body does not hold the Grok mutation flight in tests/native-grok-toggle.test.ts that opens a stalled request body and verifies a concurrent complete toggle succeeds and the stalled request later yields normal JSON validation handling.
  • Preserve the single-flight behavior for actual mutation work and keep existing refusal/error mappings (config_busy, not_installed, orphaned_marker, etc.).
  • Files changed: src/server/management/native-integration-routes.ts and tests/native-grok-toggle.test.ts.

Testing

  • Ran the focused file tests with node_modules/.bin/bun scripts/test.ts tests/native-grok-toggle.test.ts and all tests in that file passed (25 pass).
  • Ran bun run typecheck and the typecheck completed successfully.
  • Ran bun run privacy:scan and it completed successfully.
  • Attempted a full bun run test; the run exposed unrelated existing timeouts/failures in other suites (external provider-outbound/management-provider-validation tests) that are not caused by this change, so the focused regression and typecheck/scan are the validations for this fix.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6de79e4d-330a-4599-b2d2-0fca04665517

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 65d9855.

📒 Files selected for processing (2)
  • src/server/management/native-integration-routes.ts
  • tests/native-grok-toggle.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(grok): keep slow uploads outside toggle flight [WRONG BRANCH] fix(grok): keep slow uploads outside toggle flight Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 11:15
@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant