[WRONG BRANCH] fix(grok): keep slow uploads outside toggle flight - #49
[WRONG BRANCH] fix(grok): keep slow uploads outside toggle flight#49luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
grokToggleFlightbefore awaiting the request body, so a stalled/partial upload could hold the lock and cause authenticated409 config_busydenial-of-service for other toggles.Description
handleGrokToggleby callingreadManagementJsonBody(req)before checking/settinggrokToggleFlight, so stalled uploads cannot hold the flight.an incomplete request body does not hold the Grok mutation flightintests/native-grok-toggle.test.tsthat opens a stalled request body and verifies a concurrent complete toggle succeeds and the stalled request later yields normal JSON validation handling.config_busy,not_installed,orphaned_marker, etc.).src/server/management/native-integration-routes.tsandtests/native-grok-toggle.test.ts.Testing
node_modules/.bin/bun scripts/test.ts tests/native-grok-toggle.test.tsand all tests in that file passed (25 pass).bun run typecheckand the typecheck completed successfully.bun run privacy:scanand it completed successfully.bun run test; the run exposed unrelated existing timeouts/failures in other suites (externalprovider-outbound/management-provider-validationtests) that are not caused by this change, so the focused regression and typecheck/scan are the validations for this fix.