Skip to content

[WRONG BRANCH] fix(server): bound Claude Desktop apply bodies - #48

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-body-read-vulnerability
Draft

[WRONG BRANCH] fix(server): bound Claude Desktop apply bodies#48
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-body-read-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent an authenticated management caller from forcing the server to buffer an unbounded or oversized request by calling POST /api/claude-desktop/apply with req.text()-style parsing. This restores the management-plane 4 MiB guard and avoids resource-exhaustion risk.

Description

  • Replaced manual req.text() + JSON.parse in the POST /api/claude-desktop/apply handler with a bounded reader that enforces MANAGEMENT_JSON_BODY_MAX_BYTES and treats an empty body as {} for back-compat by calling readOptionalManagementJsonBody in src/server/management/agent-settings-routes.ts.
  • Added readOptionalManagementJsonBody to src/server/management/body.ts which delegates to the existing readBoundedJsonRequestBody with an empty-body fallback of {}.
  • Extended readBoundedJsonRequestBody in src/server/request-decompress.ts to accept an options.emptyBodyFallback hook and to return it for empty bodies after decompression and size checks.
  • Propagated DecompressedBodyTooLargeError handling so oversized or decompressed-oversize inputs map to the existing 413 management response path and preserved existing 400 behavior for malformed JSON.
  • Added regression tests in tests/claude-management-api.test.ts covering malformed JSON and a gzip-compressed request whose decompressed size exceeds the management limit.

Testing

  • Ran bun test tests/claude-management-api.test.ts, which passed (claude-management tests including new cases succeeded).
  • Ran bun run typecheck (bun x tsc --noEmit), which passed.
  • Ran bun run privacy:scan, which passed.
  • Ran the broader bun run test during iteration and observed a prior unrelated tests/cli-help.test.ts expectation failure in Docker-mode output; that failure is unrelated to the management-body change and did not affect the focused claude-management tests.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0635a17b-4ac1-411a-9862-171b37a98575

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and b0ad139.

📒 Files selected for processing (4)
  • src/server/management/agent-settings-routes.ts
  • src/server/management/body.ts
  • src/server/request-decompress.ts
  • tests/claude-management-api.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(server): bound Claude Desktop apply bodies [WRONG BRANCH] fix(server): bound Claude Desktop apply bodies Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 11:14
@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant