[WRONG BRANCH] fix(router): reject ambiguous provider model selectors - #47
[WRONG BRANCH] fix(router): reject ambiguous provider model selectors#47luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
deepseek/deepseek-v4-flash, whose vendor prefix collides with the built-indeepseekprovider and can cause the router to send Command Code prompts to DeepSeek instead.Description
routeModelInternal(src/router.ts) that detects when a slash-containing model selector matches a configured provider namespace while another enabled provider has that exact full id as itsdefaultModel, and throw a descriptiveAmbiguous model selectorerror instructing callers to use the encoded provider slug.tests/commandcode-provider.test.tsthat reproduces the Command Code / DeepSeek collision and verifies the ambiguous native selector is rejected while the encodedcommandcode/deepseek-deepseek-v4-flashselector still routes to Command Code.Testing
OCX_TEST_NO_QUEUE=1 node_modules/bun/bin/bun.exe test tests/commandcode-provider.test.tsand the updated file's tests passed (8 tests).bun run typecheckand the fullbun run testsuite; the suite completed successfully in the environment used for the run.bun run privacy:scanas part of validation and it completed successfully.node:zlib.zstdDecompressSyncand can causebun testfailures when invoked from the systembun; the focused tests were validated with the repository-provided Bun binary that matches expected runtime features.Codex Task