Skip to content

[WRONG BRANCH] fix(gui): avoid false empty integrations state - #43

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-false-empty-state
Draft

[WRONG BRANCH] fix(gui): avoid false empty integrations state#43
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-false-empty-state

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A failed initial read of /api/client-integrations (a failed-cold result with no data) was treated as a settled empty list, causing the Integrations Overview to show a misleading “No installed clients were detected” panel.
  • The intent is to distinguish “we never received data” from “we received an empty list” so missing file clients remain visible until a successful settlement.

Description

  • Use the resource's actual data presence to determine settlement by changing clientsSettled to statesResource.state.data !== undefined in gui/src/pages/integrations/IntegrationsOverview.tsx so a cold/failed-cold read does not count as settled.
  • Clarify the comment above the check to explain that undefined covers both pre-response and cold failures while stale failures retain previous rows.
  • Add a regression test in gui/tests/integrations-surfaces.test.tsx that simulates an HTTP 500 from the client list and asserts the load error is shown and the false empty-state panel is not rendered.

Testing

  • Ran the focused integration tests with cd gui && bun test tests/integrations-surfaces.test.tsx, and the file-level suite passed after the change (all tests in that file passed).
  • Ran cd gui && bun run lint and cd gui && bun run build, both of which completed successfully for the GUI.
  • Ran type checking with bun run typecheck, which completed successfully.
  • A broader run of the GUI test suite encountered a runtime environment incompatibility in one attempt (SyntaxError: Export named 'zstdDecompressSync' not found in module 'node:zlib'), which is unrelated to this logic change; re-running the focused GUI tests confirmed the new test and existing tests pass.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8dfaada0-cc3b-45f9-a7d2-db808e5f7ab7

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 6f6f715.

📒 Files selected for processing (2)
  • gui/src/pages/integrations/IntegrationsOverview.tsx
  • gui/tests/integrations-surfaces.test.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(gui): avoid false empty integrations state [WRONG BRANCH] fix(gui): avoid false empty integrations state Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 08:30
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant