Skip to content

[WRONG BRANCH] fix(management): reject null body in Claude native-integration toggle #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Draft

[WRONG BRANCH] fix(management): reject null body in Claude native-integration toggle #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/management/native-integration-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ export async function handleNativeIntegrationRoutes(ctx: ManagementContext): Pro
rethrowManagementBodyTooLarge(error);
return jsonResponse({ error: "invalid JSON body" }, 400);
}
if (typeof body.enabled !== "boolean") {
if (!body || typeof body !== "object" || Array.isArray(body) || typeof body.enabled !== "boolean") {
return jsonResponse({ error: "enabled must be a boolean" }, 400);
}

Expand Down
11 changes: 11 additions & 0 deletions tests/native-claude-code-toggle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,17 @@ test("a non-boolean enabled is rejected", async () => {
expect(res!.status).toBe(400);
});

test("a null body is rejected instead of crashing the route", async () => {
const { response } = dispatch(baseConfig(), "/api/native-integrations/claude", {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: "null",
});
const res = await response;
expect(res!.status).toBe(400);
expect(await res!.json()).toEqual({ error: "enabled must be a boolean" });
});

test("genuine lock contention refuses 409 config_busy, a broken lock is a 500", async () => {
/*
* `ConfigMutationLockError` wraps EVERY acquisition failure behind one
Expand Down
Loading