Skip to content

[WRONG BRANCH] fix(oauth): redact config path from stale OAuth provider error responses - #150

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-oauth-error-response-disclosure
Closed

[WRONG BRANCH] fix(oauth): redact config path from stale OAuth provider error responses#150
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-oauth-error-response-disclosure

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent leaking an absolute local config path in data-plane error responses when a routed provider uses authMode: "oauth" but its provider id is unsupported.

Description

  • Replace the error message that exposed getConfigPath() with a generic remediation phrase that no longer includes filesystem paths, leaving the 400 classification intact in src/server/responses/core.ts.
  • Remove the now-unneeded getConfigPath import from the touched module.
  • Add a regression test in tests/oauth-status-privacy.test.ts that exercises the routed stale-OAuth provider path and asserts the HTTP error body does not contain the test OPENCODEX_HOME or config.json.

Testing

  • Ran the focused test bun test tests/oauth-status-privacy.test.ts which passed locally after using the repository-pinned Bun binary (the environment default Bun lacked a zlib export needed by tests).
  • Ran bun x tsc --noEmit (typecheck) which passed with the repository toolchain.
  • Ran the full test suite via the repository test runner and bun run privacy:scan, both of which completed successfully in the test environment used for validation.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6027a127-b790-4d46-8aa4-00e12d330ee0

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 8ddde21.

📒 Files selected for processing (2)
  • src/server/responses/core.ts
  • tests/oauth-status-privacy.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(oauth): redact config path from stale OAuth provider error responses [WRONG BRANCH] fix(oauth): redact config path from stale OAuth provider error responses Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17

luvs01 commented Aug 16, 2026

Copy link
Copy Markdown
Owner Author

Superseded by upstream PR lidge-jun#1842, which ports the path-redaction fix to current dev and also sanitizes the initial and post-401 OAuth refresh error boundaries. Closing this stale main-based draft.

@luvs01 luvs01 closed this Aug 16, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01 luvs01 closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant