Add application manager for client#524
Open
elliekwon wants to merge 4 commits intolunchclass:masterfrom
Open
Conversation
romandev
reviewed
Nov 13, 2017
|
|
||
| async isCromeBrowser(): Promise<boolean> { | ||
| var agent = navigator.userAgent.toLowerCase(); | ||
| if(agent.indexOf('chrome') != -1){ |
Member
There was a problem hiding this comment.
This is not perfect. For example, Samsung Internet, Opera, Whale browser will also include the chrome keyword in UA string.
Also, Android system WebView also includes chrome keyword in UA string.
You will have to investigate more things.
Collaborator
There was a problem hiding this comment.
@elliekwon, if you are in trouble with this, take a look at the previous commit. link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application manager for client created. This pull request has only structure and test code for checking chrome browser.