Open
Conversation
lewandowskit93
force-pushed
the
feature_package_manager_support
branch
from
3c37e0f to
bb6a78f
Compare
lewandowskit93
force-pushed
the
feature_package_manager_support
branch
from
bb6a78f to
8564a4f
Compare
lewandowskit93
force-pushed
the
feature_package_manager_support
branch
from
4d013b5 to
dfaf02e
Compare
lukkas
requested changes
Jan 25, 2020
README.md
Outdated
|
|
||
| To install Visually using **Swift Package Manager** go through following steps: | ||
|
|
||
| 1. Add following package dependency in you **Package.swift** ``` .package(url: "https://github.com/lukkas/Visually.git", from: "2.0.0") ``` |
Owner
There was a problem hiding this comment.
I think I'd just leave point 1. (and of course remove the number) and maybe add some context here, like so
dependencies: [
.package(url: "https://github.com/lukkas/Visually.git", from: "2.0.0")
]I'd leave out point 2 and the example. It is just information that you can find anywhere and I wouldn't like to focus on this in README too much
Author
There was a problem hiding this comment.
The "from" must be specified for a package dependency, I suggest changing "2.0.0" to -> "VERSION_NUMBER_HERE"
what do you think?
Owner
There was a problem hiding this comment.
I meant the entire second point of the instruction, not the version number. I don't want to get too specific of how to use SPM here. I think that up to 5 lines, including snippets is enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Swift Package Manager support & fixed codecov badge