Skip to content

fix(ios): respect custom duration for Apple map camera animations #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirillKaverin wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(ios): respect custom duration for Apple map camera animations #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/shared/src/screens/HomeScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,14 @@ const HomeContent = ({ onMarkerPress: onMarkerPressProp }: HomeProps) => {
const moveToRandomMarker = () => {
if (markers.length === 0) return;
const marker = randomFrom(markers);
mapRef.current?.moveCamera(marker.coordinate);
mapRef.current?.moveCamera(marker.coordinate, { duration: 2000 });
mapRef.current?.showMarkerCallout(marker.id);
};

const fitAllMarkers = () => {
mapRef.current?.fitCoordinates(
markers.map((m) => m.coordinate),
{ padding: { top: 60, left: 40, right: 40, bottom: 40 } }
{ duration: 2000, padding: { top: 60, left: 40, right: 40, bottom: 40 } }
);
};

Expand Down
4 changes: 2 additions & 2 deletions ios/core/AppleMapProvider.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,7 +1778,7 @@ - (void)moveCamera:(double)latitude
zoomLevel:targetZoom];
[UIView animateWithDuration:duration / 1000.0
animations:^{
[self->_mapView setRegion:region animated:NO];
[self->_mapView setRegion:region animated:YES];
}];
} else {
[_mapView
Expand Down Expand Up @@ -1823,7 +1823,7 @@ - (void)fitCoordinates:(NSArray *)coordinates
animations:^{
[self->_mapView setVisibleMapRect:mapRect
edgePadding:insets
animated:NO];
animated:YES];
}];
} else {
[_mapView setVisibleMapRect:mapRect edgePadding:insets animated:NO];
Expand Down