Merged
Conversation
Use custom LuggCalloutContentView with intrinsicContentSize override so Auto Layout can size detailCalloutAccessoryView properly.
Marker callout support for iOS (Apple Maps + Google Maps), Android (Google Maps), and Web.
Remove standalone Callout component. Callout is now configured via
Marker props: callout, onCalloutPress, calloutBubbled.
When calloutBubbled={false}, render live interactive views above the
marker instead of rasterized info windows, enabling buttons and
other interactive content inside callouts on all platforms.
Compute content bounds from children instead of contentView dimensions (which are always 0 since it's not Yoga-managed). Run positioning synchronously to avoid the initial flash at (0,0).
Measure and layout contentView once on show so Android's hit testing recognizes its bounds. Position updates on camera move only update translation for performance.
Support anchor-based positioning for non-bubbled callouts on all platforms. Reposition callout when content size or anchor changes.
…oning AdvancedMarker.iconView is buggy on Android. For non-rasterized markers, manually add iconView to the wrapper and position via screen projection with pointerEvents=NONE so taps pass through to the underlying marker.
- support title/description callouts on web markers - close callouts on map click - disable InfoWindow header for native consistency - add FeatureProperties type with title, description, stroke, fill - use ThemedText in example app
- Guard null oldProps in LuggCalloutView updateProps (crash fix) - Deduplicate annotation view hit-test logic into shared helpers - Add removeViews override for safe batch child removal on Android - Use stable hasCallout boolean in web Marker handleClick deps - Guard re-entrancy in Apple Maps didDeselectAnnotationView - Dismiss non-bubbled callout on Apple Maps destroy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Calloutcomponent for displaying callouts when markers are tapped. Supports custom React content and press handling across all platforms.Type of Change
Test Plan
onPressChecklist