Skip to content

DM-54862: Enable ExtendednessTool-like behavior#480

Open
arunkannawadi wants to merge 1 commit intomainfrom
tickets/DM-54862
Open

DM-54862: Enable ExtendednessTool-like behavior#480
arunkannawadi wants to merge 1 commit intomainfrom
tickets/DM-54862

Conversation

@arunkannawadi
Copy link
Copy Markdown
Member

for backward compatibility. This introduces the deprecation that was missed in #478 .

@arunkannawadi arunkannawadi requested a review from taranu May 4, 2026 22:56
Copy link
Copy Markdown
Contributor

@taranu taranu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to re-introduce parametrizedBand as a Field for now.

Either way, my main comment is that I missed doing the same thing for ColumnMagnitudeScatterPlot, also in atools. That's the last remaining "use" of ExtendednessTool, so it could be deprecated after that. Since you've already made the removal, I figure it would be better to at least get rid of all uses of it on this ticket. I can add the commit to do that if you like.

Arguably deprecating ExtendednessTool itself should be another ticket and/or trivial RFC, since it is a public interface - up to you, I suppose.

Comment thread python/lsst/analysis/tools/atools/sizeMagnitude.py
Comment thread python/lsst/analysis/tools/atools/sizeMagnitude.py Outdated
for backward compatability.
@arunkannawadi
Copy link
Copy Markdown
Member Author

@taranu I've made the changes in ColumnMagnitudeScatterPlot. I decided against reintroducing these as Field instances again: as config fields, they'd be persisted, regardless of their deprecation status, and given that they were removed, reintroducing them seems a step backwards to me. They are now as close as they can be to what they would become after removal - a class attribute.

As for deprecating ExtendednessTool itself, I'll leave that up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants