DM-54862: Enable ExtendednessTool-like behavior#480
DM-54862: Enable ExtendednessTool-like behavior#480arunkannawadi wants to merge 1 commit intomainfrom
Conversation
taranu
left a comment
There was a problem hiding this comment.
It may be better to re-introduce parametrizedBand as a Field for now.
Either way, my main comment is that I missed doing the same thing for ColumnMagnitudeScatterPlot, also in atools. That's the last remaining "use" of ExtendednessTool, so it could be deprecated after that. Since you've already made the removal, I figure it would be better to at least get rid of all uses of it on this ticket. I can add the commit to do that if you like.
Arguably deprecating ExtendednessTool itself should be another ticket and/or trivial RFC, since it is a public interface - up to you, I suppose.
for backward compatability.
788b6c5 to
fb36441
Compare
|
@taranu I've made the changes in As for deprecating |
for backward compatibility. This introduces the deprecation that was missed in #478 .