fix: prevent max_tokens state mutation and clean up dead code#465
Open
Kailigithub wants to merge 1 commit into
Open
fix: prevent max_tokens state mutation and clean up dead code#465Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
- Use local variable instead of mutating self.max_tokens in ClaudeSession.raw_ask and NativeClaudeSession.raw_ask - Replace json.loads(json.dumps(...)) with copy.deepcopy() in ToolClient.chat for more efficient deep copy - Fix dead code in TMWebDriver connected() callback (missing print)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three targeted fixes in the LLM core and browser driver:
Prevent
max_tokensstate mutation (llmcore.py):ClaudeSession.raw_askandNativeClaudeSession.raw_askwere mutatingself.max_tokensto 8192 whenNone.max_tokens = self.max_tokens or 8192instead.Replace redundant JSON round-trip with
copy.deepcopy()(llmcore.py):ToolClient.chat()usedjson.loads(json.dumps(tools, ensure_ascii=False))to deep-copy the tools schema.copy.deepcopy()is cleaner, faster for non-JSON-serializable objects, and clearer in intent.Fix dead code in
TMWebDriver(TMWebDriver.py):connected()callback created a string but never printed or returned it.print()call to matchhandle_close()behavior.Verification:
python3 -m py_compile