fix: replace bare except clauses with except Exception#463
Open
Kailigithub wants to merge 1 commit into
Open
Conversation
Replace 44 bare statements across 14 files with . Bare except clauses catch SystemExit and KeyboardInterrupt which should propagate normally. This is a safe drop-in replacement that preserves existing error handling behavior while fixing the E722 lint violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 44 bare
except:statements withexcept Exception:across 14 source files.Bare
except:clauses catch all exceptions includingSystemExitandKeyboardInterrupt, which should normally propagate. This is a standard Python best practice (PEP 8 / E722) fix.Changes:
llmcore.py— 16 occurrences (SSE parsing, JSON decode, retry logic)ga.py— 8 occurrences (code execution, file I/O, verbose print)simphtml.py— 4 occurrences (DOM monitoring, page diff)agentmain.py— 3 occurrences (session init, LLM client switch)frontends/qtapp.py— 2 occurrences (message rendering)frontends/stapp.py— 2 occurrences (stdout/stderr reconfigure)frontends/stapp2.py— 2 occurrences (stdout/stderr reconfigure)Verification:
python3 -m py_compilesyntax checkruff check --select E722shows 0 remaining violationsExceptioncatches the same errors as bareexceptin all these cases