[cov,test] Fix hardcoded flash layout constants#29269
Merged
timothytrippel merged 2 commits intolowRISC:earlgrey_1.0.0from Feb 19, 2026
Merged
[cov,test] Fix hardcoded flash layout constants#29269timothytrippel merged 2 commits intolowRISC:earlgrey_1.0.0from
timothytrippel merged 2 commits intolowRISC:earlgrey_1.0.0from
Conversation
The flash layout constants in several tests were hardcoded, assuming a 64K ROM_EXT. This caused tests to fail when linked for coverage, as the coverage-enabled ROM_EXT is 128K. This change replaces the hardcoded constants with calculated values or named constants that account for the size of the ROM_EXT. Change-Id: I29f0796eec59d4fd9c70fdb0b72d3c70f17da9a4 Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com>
sasdf
force-pushed
the
mgT29f0796e
branch
2 times, most recently
from
a57238e to
d14f4da
Compare
Under coverage mode, the ROM_EXT size increases, which can break the flash layout assumptions in certain tests. This change introduces specific constants for production and coverage builds and ensures that owner_block unit tests use the production flash layout even when coverage is enabled. Change-Id: I52e17fe8fe17f2d98456a25a77c19066e2ee0703 Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com>
cfrantz
approved these changes
Feb 9, 2026
timothytrippel
merged commit bf40267
into
lowRISC:earlgrey_1.0.0
33 of 34 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flash layout constants in several tests were hardcoded, assuming a 64K ROM_EXT. This caused tests to fail when linked for coverage, as the coverage-enabled ROM_EXT is 128K.
This PR replaces the hardcoded constants with calculated values or named constants that account for the size of the ROM_EXT.