Added chip level I2C Device TX_RX test#633
Open
KinzaQamar wants to merge 3 commits into
Open
Conversation
KinzaQamar
force-pushed
the
i2c_device_smoke
branch
5 times, most recently
from
dafa77b to
c434d75
Compare
KinzaQamar
force-pushed
the
i2c_device_smoke
branch
2 times, most recently
from
fbf55a9 to
13af90e
Compare
KinzaQamar
requested review from
elliotb-lowrisc,
engdoreis,
marnovandermaas,
martin-velay and
ziuziakowska
KinzaQamar
force-pushed
the
i2c_device_smoke
branch
3 times, most recently
from
81bb879 to
3f1a2ff
Compare
…vice Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_device_smoke
branch
2 times, most recently
from
d5e3010 to
74cf3b0
Compare
KinzaQamar
commented
Jun 26, 2026
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_device_smoke
branch
from
74cf3b0 to
0646a31
Compare
engdoreis
approved these changes
Jun 26, 2026
engdoreis
left a comment
engdoreis
left a comment
Collaborator
There was a problem hiding this comment.
I left a suggestion, otherwise it LGTM.
| VOLATILE_WRITE(i2c->txdata, txdata); | ||
| } | ||
|
|
||
| void i2c_clear_cmd_complete(i2c_t i2c) |
Collaborator
There was a problem hiding this comment.
I suggest making a function to clear interrupts that take the interrupt as argument like uart:
mocha/sw/device/lib/hal/uart.c
Line 36 in 3b3b9e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a host Vseq and device SW. The host will initiate read / write transfer. The device SW waits for the transfers to finish and compare the data bytes in each transfer at the end