[cheriot,rtl] Integrate TRVK filter into Ibex Top#2456
Draft
thommythomaso wants to merge 3 commits into
Draft
Conversation
The `stream_fork` and `stream_join` modules are used in some CHERIoT memory IPs. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
4 times, most recently
from
9a2ee2d to
748b234
Compare
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
1 task
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
2 times, most recently
from
f8eaaff to
8348e15
Compare
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
20 tasks
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
from
8348e15 to
c2bd352
Compare
andreaskurth
reviewed
Jul 3, 2026
andreaskurth
left a comment
andreaskurth
left a comment
Contributor
There was a problem hiding this comment.
Mostly LGTM, thanks @thommythomaso!
A few comments/suggestions below
Comment on lines
+1285
to
+1286
| trvk_revbm_data_intg_error | | ||
| trvk_revbm_device_error; |
Contributor
There was a problem hiding this comment.
Shouldn't these feed into alert_major_bus_o? Potentially worth discussing with Pascal and/or Pirmin
| .trvk_revbm_addr_o ( ), | ||
| .trvk_revbm_rdata_i ('b0 ), | ||
| .trvk_revbm_rdata_intg_i ('b0 ), | ||
| .trvk_revbm_err_i ( ), |
Contributor
There was a problem hiding this comment.
Suggest tying off (only the last line)
| trvk_revbm_rdata_i, | ||
| trvk_revbm_rdata_intg_i, | ||
| trvk_revbm_err_i, | ||
| trvk_rtag, |
Contributor
There was a problem hiding this comment.
suggest tying off in this branch (only the last line) - otherwise it's both undriven and unused, which may cause lint problems
Comment on lines
16
to
+26
| @@ -21,6 +22,8 @@ module ibex_top import ibex_pkg::*; #( | |||
| parameter ibex_pkg::pmp_cfg_t PMPRstCfg[PMP_MAX_REGIONS] = ibex_pkg::PmpCfgRst, | |||
| parameter logic [PMP_ADDR_MSB:0] PMPRstAddr[PMP_MAX_REGIONS] = ibex_pkg::PmpAddrRst, | |||
| parameter ibex_pkg::pmp_mseccfg_t PMPRstMsecCfg = ibex_pkg::PmpMseccfgRst, | |||
| parameter int unsigned CheriotRevBitmapAddrWidth = 32'd9, | |||
| parameter int unsigned CheriotRevBitmapBaseAddr = 32'h0, | |||
Contributor
There was a problem hiding this comment.
Suggest documenting the new parameters in integration.rst. Not a blocker - if you prefer to do this later, please create an issue.
Similarly, I suggest describing the internal workings of this PR and #2455 in the reference guide - also not blocking but should be tracked in an issue if defered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2455.