decoder: Prevent memory side-effects on taken branch and add verification testbench#2386
Open
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Open
decoder: Prevent memory side-effects on taken branch and add verification testbench#2386Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves pipeline safety by ensuring that no memory
requests are issued when a branch is taken.
This avoids unintended memory accesses during control flow changes.
A testbench is added to verify that data_req_o and data_we_o
are correctly disabled when branch_taken_i is asserted.
This aligns the decoder behavior with real hardware expectations
and improves pipeline correctness.