Fix: Ensure safe control signal reset on illegal instruction#2380
Open
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Open
Fix: Ensure safe control signal reset on illegal instruction#2380Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves decoder robustness by ensuring all relevant control
signals are safely reset when an illegal instruction is detected.
Previously, signals like rf_ren_a_o, rf_ren_b_o, icache_inval_o and csr_op_o
could retain stale values, potentially causing unintended hardware behavior.
This change aligns the decoder with safe hardware design practices
and improves reliability.