[rtl] Stop rvfi from reporting load information on stores#2337
Merged
SamuelRiedel merged 1 commit intolowRISC:masterfrom Dec 3, 2025
Merged
[rtl] Stop rvfi from reporting load information on stores#2337SamuelRiedel merged 1 commit intolowRISC:masterfrom
SamuelRiedel merged 1 commit intolowRISC:masterfrom
Conversation
Contributor
Author
rswarbrick
approved these changes
Dec 3, 2025
Contributor
rswarbrick
left a comment
There was a problem hiding this comment.
Makes sense to me (and I like the way it's now more symmetrical with the following line too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the trace does not incorrectly report load data during memory store operations. Currently, the tracer uses the
rmaskandwmaskto print information about loads and stores:ibex/rtl/ibex_tracer.sv
Lines 136 to 145 in 0a13971
While the
wmaskwas already gated in thervfi, thermaskwas always enabled, which led to load data being reported even during a store.