types: return more precise Buffer<ArrayBuffer> from toBuffer#4520
Open
Andarist wants to merge 1 commit intolovell:mainfrom
Open
types: return more precise Buffer<ArrayBuffer> from toBuffer#4520Andarist wants to merge 1 commit intolovell:mainfrom
Buffer<ArrayBuffer> from toBuffer#4520Andarist wants to merge 1 commit intolovell:mainfrom
Conversation
Andarist
commented
Apr 10, 2026
Comment on lines
+172
to
+176
| "peerDependenciesMeta": { | ||
| "@types/node": { | ||
| "optional": true | ||
| } | ||
| }, |
Author
There was a problem hiding this comment.
I think this is kinda more compatible with strict package managers like pnpm. If you'd like to declare an explicit range for compatible @types/node then you'd have to declare the range within a regular peerDependencies declaration and, in here, the correct range would be something like:
^18.19.54 || ^20.16.10 || >=22.7.4
Those are the versions published on 2024-09-27 and they introduced this change: DefinitelyTyped/DefinitelyTyped#70694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.