chore: migrate steam to an monitoring type and add a test#6652
Open
CommanderStorm wants to merge 13 commits intolouislam:masterfrom
Open
chore: migrate steam to an monitoring type and add a test#6652CommanderStorm wants to merge 13 commits intolouislam:masterfrom
CommanderStorm wants to merge 13 commits intolouislam:masterfrom
Conversation
CommanderStorm
added
the
pr:needs review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
CommanderStorm
force-pushed
the
steam-monitoring-type
branch
from
2c91e66 to
410eb92
Compare
CommanderStorm
force-pushed
the
steam-monitoring-type
branch
from
410eb92 to
738900a
Compare
| httpsAgent: new https.Agent({ | ||
| maxCachedSessions: 0, // Use Custom agent to disable session reuse (https://github.com/nodejs/node/issues/3940) | ||
| rejectUnauthorized: !monitor.ignoreTls, | ||
| secureOptions: crypto.constants.SSL_OP_LEGACY_SERVER_CONNECT, |
There was a problem hiding this comment.
This shouldn't be needed here, api.steampowered.com supports secure renegotiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
We should move the code for the steam monitor to be a monitoring type.
This PR does this