-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Start on encrypted matrix notification implementation #6453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Start on encrypted matrix notification implementation #6453
Conversation
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you want a review yet. this is still a draft.
Instead of adding this to a new notification provider, could you add this to the regular matrix notification instead, but with a selector if a user wants the non-encrypted vs non-encrypted?
|
Yeah I still want to work on this. Will change that. My problem currently is that I cannot feet the matrix season of uptime kuma verified. Therefore it is encrypted but has an indicator with a red exclamation mark saying that the senders session isn't verified. If someone has an idea on how to fix that lmk |
|
CC people who messaged in the thread if they have an idea to getting verified by matrix. |
| await new Promise((resolve) => { | ||
| MatrixEncrypted.client.once("sync", (state) => { | ||
| if (state === "PREPARED") resolve(); | ||
| }); | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be the issue for the verification, but I am not a huge matrix user, so don't know.
@cestoliv is doing the following here
await new Promise<void>((resolve) => {
this.matrixClient.once(ClientEvent.Sync, () => {
// Send encrypted message, even if member isn't trusted
this.matrixClient.setGlobalErrorOnUnknownDevices(false)
resolve()
})
})| accessToken: notification.accessToken, | ||
| userId: notification.userId, | ||
| deviceId: notification.deviceId, | ||
| //cryptoStore: MatrixEncrypted.store, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this?
|
|
||
| log.info("Matrix", "Sending encrypted message…"); | ||
|
|
||
| await MatrixEncrypted.client.sendMessage(notification.internalRoomId, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you need to join the room here and upload the keys (whatever this does) here?
❗ Important Announcements
Click here for more details:
🚫 Please Avoid Unnecessary Pinging of Maintainers
We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.
📋 Overview
matrix-js-sdk: ^39.3.0: Matrix sdk required for implementation of matrix functionality. Simple api calls aren't enough anymore as key exchanges are more complex.@matrix-org/matrix-sdk-crypto-nodejs: ^0.4.0-beta.1: Crypto module required bymatrix-js-sdkfor e2ee.🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
UPDOWN